- please never use list_for_each in new code but list_for_each_entryje docela pochopitelné i pro laika. Duplikovaný kód, používání starých funkcí, atp.
- never use kernel_thread in new code but kthread_*
- do_sendfile duplicates the common sendfile code. why aren't you using the generic code?
- there's tons of really useless assertation of the category discussed in the last thread
- there's tons of deep pagecache messing in there. normally this shouldn't be a filesystem, and if this breaks because of VM changes you'll have to fix it, don't complain..
- you still do your plugin mess in ->readpage. honsetly could you please explain why mpage_readpage{,s} don't work for you?
- (issues with the read/write path already addresses in the previous thread)
- looking at ->d_count in ->release is wrong
- still has security plugin stuff that duplicates LSM
- why do underlying attributes change when VFS inode doesn't change? if not please rip out most of getattr_common
- link_common S_ISDIR doesn't make sense, VFS takes care of it
- please use the generic_readlink infrastructure